fix: address code quality issues in session pool, approval, and main

- session.ts: add onReconnect callback so reconnected socket replaces stale pool entry
- session-pool.ts: pass onReconnect to update pool on reconnect; add closeAll() to gracefully end WebSocket connections on shutdown
- approval.ts: use approved flag so double-approval race (updateMany count=0) returns null instead of sending duplicate forward jobs
- main.ts: wrap pool.add() in try/catch to continue if one account fails; replace silent groupMap fallback with explicit error log and early return; call pool.closeAll() before BullMQ shutdown to prevent hanging sockets
- Tests: add closeAll() test to session-pool.test.ts; add double-approval race test to approval.test.ts (56 tests total, all passing)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

apps/worker/src/whatsapp/session-pool.test.ts

@@ -5,6 +5,7 @@ jest.mock('./session', () => ({
   createWhatsAppSession: jest.fn().mockResolvedValue({
     sendMessage: jest.fn().mockResolvedValue({}),
     logout: jest.fn().mockResolvedValue({}),
+    end: jest.fn(),
   }),
 }));
 
@@ -55,6 +56,21 @@ describe('WhatsAppSessionPool', () => {
     await expect(pool.remove('acc_unknown')).resolves.not.toThrow();
   });
 
+  it('closeAll() calls end() on all sessions and clears the pool', async () => {
+    await pool.add('acc_1', './sessions/1', jest.fn(), jest.fn(), jest.fn());
+    await pool.add('acc_2', './sessions/2', jest.fn(), jest.fn(), jest.fn());
+    expect(pool.getAll().size).toBe(2);
+
+    const sock1 = pool.get('acc_1')!;
+    const sock2 = pool.get('acc_2')!;
+
+    await pool.closeAll();
+
+    expect(sock1.end).toHaveBeenCalledWith(undefined);
+    expect(sock2.end).toHaveBeenCalledWith(undefined);
+    expect(pool.getAll().size).toBe(0);
+  });
+
   it('add() injects accountId into onMessage callback', async () => {
     const onMessage = jest.fn();
     const { createWhatsAppSession } = require('./session');

apps/worker/src/whatsapp/session-pool.ts

@@ -28,6 +28,10 @@ export class WhatsAppSessionPool {
       (msg) => onMessage(msg, accountId),
       (reaction) => onReaction(reaction, accountId),
       (groups) => onGroups(groups, accountId),
+      (newSocket) => {
+        logger.info({ accountId }, 'Session reconnected — updating pool');
+        this.sessions.set(accountId, newSocket);
+      },
     );
     this.sessions.set(accountId, sock);
   }
@@ -57,4 +61,17 @@ export class WhatsAppSessionPool {
       logger.info({ accountId }, 'Session removed');
     }
   }
+
+  async closeAll(): Promise<void> {
+    logger.info({ count: this.sessions.size }, 'Closing all WhatsApp sessions');
+    for (const [accountId, sock] of this.sessions) {
+      try {
+        sock.end(undefined);
+        logger.info({ accountId }, 'Session closed');
+      } catch (err) {
+        logger.error({ accountId, err }, 'Error closing session');
+      }
+    }
+    this.sessions.clear();
+  }
 }

apps/worker/src/whatsapp/session.ts

@@ -23,6 +23,7 @@ export async function createWhatsAppSession(
   onMessage: OnMessageCallback,
   onReaction: OnReactionCallback,
   onGroups: OnGroupsCallback,
+  onReconnect?: (newSocket: WASocket) => void,
 ): Promise<WASocket> {
   const { state, saveCreds } = await useMultiFileAuthState(sessionPath);
   const { version } = await fetchLatestBaileysVersion();
@@ -46,10 +47,17 @@ export async function createWhatsAppSession(
       logger.info({ reason, shouldReconnect }, 'Connection closed');
       if (shouldReconnect) {
         logger.info('Reconnecting in 5s...');
-        setTimeout(
-          () => createWhatsAppSession(accountId, sessionPath, onMessage, onReaction, onGroups),
-          5000,
-        );
+        setTimeout(async () => {
+          const newSocket = await createWhatsAppSession(
+            accountId,
+            sessionPath,
+            onMessage,
+            onReaction,
+            onGroups,
+            onReconnect,
+          );
+          onReconnect?.(newSocket);
+        }, 5000);
       }
     } else if (connection === 'open') {
       try {